Add HTTP examples for POST PUT DELETE #849
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
requested changes
Jul 28, 2025
Examples/DeleteJSON/DeleteJSON.swift
Outdated
| @main | ||
| struct PostJSON { | ||
| static func main() async throws { | ||
| let httpClient = HTTPClient(eventLoopGroupProvider: .singleton) |
There was a problem hiding this comment.
You can actually use HTTPClient.shared instead here which you don't need to shutdown
There was a problem hiding this comment.
fixed by e3e7f31
out of curiosity what is the best practice between using the shared vs creating your own client on the fly?
glbrntt
requested changes
Jul 28, 2025
iwa
force-pushed
the
chore/add-more-http-examples
branch
from
2cb31f4 to
387bc3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi!
thanks a lot for your great lib
one thing really missing tho is more examples to help newbies using your lib, so i've added a few really basic ones to at least show how to use Post, Put & Delete
examples are made about a little local Todo api, nothing extravagant
let me know if something isn't right for y'all!